Skip to content

test: use public-relative vite paths and pin the merged framework and inertia builds - #173

Merged
hwbrzzl merged 4 commits into
masterfrom
run-20261110-154500
Nov 11, 2026
Merged

hwbrzzl merged 4 commits into
masterfrom
run-20261110-154500

Conversation

@goravel-agent

@goravel-agent goravel-agent commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • vite.build_directory / vite.hot_file are leaves inside public now (build, hot), so {{ vite }} resolves the same manifest and hot file as before while the dev-server hot file stops being looked up at public/public/hot; the dead inertia.vite map is gone.
  • Pins goravel/framework v1.18.1-0.20261110120158-82c6a43353b4 (the #1606 merge) and goravel/inertia v1.18.1-0.20261110120219-2a36f31baeaa (the Upgrade v1.12.0 #8 merge), with go mod tidy advancing grpc, golang.org/x/exp, and golang.org/x/tools to the versions those merged modules require.
  • The feature suite pins the new semantics: config-seeded vite.inputs / vite.assets merged with the view-declared entries (deduplicated, sorted), the view scan still covered on its own, and ManifestHash() compared against the md5 of the manifest bytes on disk.

Why

Framework goravel/framework#1606 re-roots the Vite config paths under public, merges vite.inputs / vite.assets into what vite:inputs scans from the views, and exposes the build manifest's hash as the asset version. goravel/inertia#8 drops its own Vite config and delegates {{ vite }} to the framework module. Both are merged now, so this branch pins their merge commits and builds against published versions rather than PR heads — nothing else has to land first.

That makes the example the end-to-end proof that the new path semantics, the seeded inputs, and the manifest hash behave as the framework documents: the config keeps serving identical URLs, and the tests fail if a view-only input goes missing or the hash stops tracking a rebuild.

// Before: the path named public itself, which the framework rooted under public
// again, so the dev server's hot file was looked for at public/public/hot.
config.Add("vite", map[string]any{
	"hot_file": "public/hot",
})

// After: paths are leaves inside public, and the app keeps serving the same URLs.
config.Add("vite", map[string]any{
	"hot_file": "hot",
})

@goravel-agent
goravel-agent requested a review from a team as a code owner November 10, 2026 11:12
@goravel-agent goravel-agent changed the title test: pin framework #1606 and inertia #8 heads and use public-relative vite paths test: use public-relative vite paths and pin the merged framework and inertia builds Nov 10, 2026
@hwbrzzl
hwbrzzl merged commit 7100d76 into master Nov 11, 2026
9 checks passed
@hwbrzzl
hwbrzzl deleted the run-20261110-154500 branch November 11, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants